Duet Web Control wishlist notes and priorities

[wilriker]

@chrishamm said in Duet Web Control wishlist notes and priorities:

• Move steps for each axis and extruder amounts+feedrates can be changed via right-click\

As mentioned before I really like this feature. I just tried it with a M291 pop-up (as it would be used for e.g. manual mesh bed leveling) and it also works there but only partially. It will create the dialog to enter the new value but it will be hidden behind the M291 dialog which is modal and over everything else.

EDIT: Now I just tried to change the value after clicking OK on the M291 dialog (which leaves the change-value-dialog open and it gets accessible that way) but when I click on OK then I get

A JavaScript error has occurred so the web interface has closed the connection to your board. It is recommended to reload the web interface now. If this happens again, please contact the author and share this error message:

Version: 1.21.2-b1
Message: Uncaught TypeError: Cannot set property '0' of undefined
URL: http://duet.localhost:8080/js/dwc.js
Line: 6419:64
Error object: {}

This might be due to the fact that the control that should be adjusted is already closed at that point.

Sadly this is the very point where I would need this functionality.

EDIT 2: Played a little more with it. I made the change dialog accessible (by juggling around in the order of the source code and setting top: 250px for this dialog in Chrome Dev Tools) and it still will fail due to the fact that stepChangeAxisIndex is -1 in this case.

[Catalin_RO]

@chrishamm said in Duet Web Control wishlist notes and priorities:

Move steps for each axis and extruder amounts+feedrates can be changed via right-click\

Could we also have more move steps buttons in a future version?

[Ethelred]

+1 for more move steps buttons.

[chrishamm]

TBH I never intended to make the move buttons configurable on the M291 dialog so this was in fact a bug which has been resolved in my current beta 2. This version is now available here: https://github.com/chrishamm/DuetWebControl/blob/dev/DuetWebControl-1.21.2-b2.zip Here the changelog once more:

• Custom themes can be used by uploading own .theme.css files
• Compensation type is shown in the Auto Calibration dropdown menu
• Fan and heater names can be assigned (see M305 S and M106 C parameters)
• Use "axes" value instead of "xyz" length to get number of configured axes
• DWC reloads itself/its settings when it/its settings are updated
• Implemented possibility to download the G-code log as a CSV or TXT file
• Webcam image can be flipped and rotated on demand
• Improved settings behavior when running on localhost
• Minor other changes
• Bug fix: Tool Fan was always updated even if the user tried to change its value
• Bug fix: Sometimes codes could be accidentally sent twice when the auto-completion was open
• Bug fix: Successful G-codes were added to the list of auto-complete items even if they had been sent from a button
• Bug fix: G1 S2 moves were incorrectly generated for jog movements on Delta and SCARA configurations
• Bug fix: Movement steps could be changed on modal dialogs

Be aware that you will need another firmware build in order to be able to rename your non-virtual heaters and fans. You can get my latest firmware build here: https://www.dropbox.com/s/kbjp5pp3wowwhot/Duet2CombinedFirmware.bin?dl=0 The corresponding sources can be found on the v2-chrishamm branch of dc42's firmware repository.

Please let me know if you encounter any problems or if everything is working well!

[JoergS5]

@wilriker said in Duet Web Control wishlist notes and priorities:

stepChangeAxisIndex

You could try analyzing the JavaScript code. Your variable which is set to -1 is in modals.js lines 53 to 86. This is code which is newly added between b1 and b2.

If stepChangeAxisIndex is -1, so the array settings.axisMoveStep[][] is invalid. The method who calls showStepDialog sends a wrong third parameter (axisIndex).

I would change
if (stepChangeType == "axis") {
settings.axisMoveSteps[stepChangeAxisIndex][stepChangeIndex] = $("#input_step_amount").val();
in line 72-73

into
if (stepChangeType == "axis") {
if(stepChangeAxisIndex >= 0) {
settings.axisMoveSteps[stepChangeAxisIndex][stepChangeIndex] = $("#input_step_amount").val();
}

as a quick fix. But the method should not be called if the axisIndex is not defined.

[wilriker]

@chrishamm said in Duet Web Control wishlist notes and priorities:

TBH I never intended to make the move buttons configurable on the M291 dialog so this was in fact a bug which has been resolved in my current beta 2.

In this case I see this new feature rather as a regression.
For me 0.1mm as lowest value was always too large when doing manual mesh bed leveling (this might be personal preference over real need but yeah, that's me ).
So I could at least use the option in UI settings to half the values of all Z-movement buttons everywhere.

Now I am stuck with the previous defaults at the place where I would need modifying primarily but I am able to modify all other buttons - where I was happy with the default.

I know I can just modify reprap.htm.gz (and in fact that is what I did with the current DWC beta) but since these values are modifiable everywhere else I would find it more consistent to also be able to modify them on M291 dialogs - or at least get this "half Z-movements" option back.

Ah! I see that the values for the M291 dialog are now bound to the same values that are used in Machine Control. That's something I can live with very well! Thank you.

[Phaedrux]

@chrishamm Small issue.

I updated to DWC 1.21.2 b1 and noticed that all of the list items for Gcodes and temperatures had been reset.

I updated to DWC 1.21.2 b2 and your customized version of RTOS 2.0b1 and now the list items for custom gcodes have been replaced by numbers and there doesn't appear to be any way to add new ones.

[Ethelred]

Unable to add new bed or extruder temperatures via the List Item page. DWC disconnects. Worked in older version.

[zerspaner_gerd]

This is also a nice new feature:

---

For some time now, I have always had a double FAN ("Tool Fan") slider

Slider 1 and 2 is for the same fan.

[wilriker]

I found a minor issue in the latest beta (possibly older versions, too):
The text of the title attribute for
Machine Status -> Sensors -> Vin lists minimum and maximum voltage but appends °C instead of V as a unit.

[T3P3Tony]

@wilriker thanks, I think you mean the "hover text"?

just clarifying so @chrishamm can find it easier!

[wilriker]

@t3p3tony I actually referred to the HTML title attribute of the related <td> tag. So we are both right.

P.S.: Updated original post to be more clear.

[T3P3Tony]

@wilriker apologies

[Phaedrux]

@chrishamm I've been testing 1.21.2-b2 and your firmware build for a while and things seem to be working alright. One thing I have noticed is that the auto-complete in the G-code console seems to be rather aggressive. If you have several entries in the list and you try and manually enter a shorter version of the command you have to press escape to close the auto complete list before you can enter it.

Example, if the list has M566 X1000 Y1000, M566 E999, M566 X10 Y10, and you want to just enter M566 without any parameters the auto complete will insist on highlighting one of the previous values with parameters until you press escape. Once it's been entered once without parameters it will go into the list and will be selected going forward, but the first time you try and enter it can be rather confusing and frustrating.

[wilriker]

I can confirm what @Phaedrux reports about the auto-completion.

[dc42]

I can confirm this about the auto completion too, in addition it seems to be case-insensitive which can be a problem sometimes.

[chrishamm]

If you can, please update to my latest beta here: https://github.com/chrishamm/DuetWebControl/blob/dev/DuetWebControl-1.22-b1.zip The changelog this time is:

• Minor layout changes
• Removed fotomas's Dark theme in favour of standard Slate theme
• Improved theme support for standard Boostrap 3 themes
• Added a few new Bootstrap 3 themes from bootswatch.com
• Added MCU temperature to Sensors panel
• Added machine mode string to the Machine Status panel (requires latest RRF version)
• Made usage of localStorage optional
• Greatly improved automatic reconnect behaviour
• Added more movement buttons for XL displays (>= 1500px)
• Clicking on the axis coordinates allows setting them directly via G92
• Factory defaults of DWC can be stored as dwc_factory.json on the SD card in /www
• Bug fix: G-Code auto completion always selected the first entry
• Bug fix: Some elements were not named correctly causing the W3C validation to fail
• Bug fix: Units of min+max voltages were wrong
• Minor OEM enhancements

!! IMPORTANT !! I no longer support fotomas's dark theme, so please do not be surprised that the web interface looks fairly bad if you used it before. Instead of the Dark theme I suggest you change to the Slate theme which will look similar but cleaner IMHO. Also, there are plenty of Bootstrap 3 themes out there, so if find any other theme that looks nice with DWC, please let me know and I will add it provided the license is OK. To install it, just rename it to <themename>.theme.css and upload it on via the Upload button on DWC. After reloading the web interface, it should be available for selection.

If you notice any more problems, please let me know. AFAICS there is only one problem concerning the extruder drive positions that I am still trying to track down but if no other issues show up, I hope I can finally publish a "real" release for v1.22 soon.

@zerspaner_gerd The first two fans are identical because the default tool fan is #0. You could customise that via M563 though.

[ShadowX]

Any chance of adding function to download all the macros as a zip file instead of just having a "delete" option only?

[Phaedrux]

@shadowx that would be handy. In the meantime the easiest way to download all the macros (or anything else on the SD card) without removing the card itself is to setup an FTP connection.

Filezilla is the recommended client.

[wilriker]

@chrishamm Thanks for the new version! I can confirm that both the wrong units for voltages as well as the aggressiveness of the auto-completion have been fixed.

I personally like the new Slate theme a lot over the old Dark theme. Only thing I will probably change is the background color for input fields as well as the text-editor modal to #AAA as the white background is too much of a contrast IMHO.

I also like the new arrangement at the top.

But I found an inconsistency (already in previous beta, not sure about earlier version) in the size of the baby-stepping buttons: They are asymmetric if there is not enough horizontal space

I get that they need to adapt as they are responsive I just don't like that they adapt individually. I'd rather have both of them be tall instead just one of them. My CSS-fu is far from being good so I have no clue if this can even be achieved at all but my inner-symmetry-requirements would love to see this being changed.

EDIT: One more enhancement might be nice: in the sensors section if you hover the Vin value you get min and max for it as title text. The same could be done for MCU temp as the values are also provided with the full response.

EDIT 2: Only just now realized: where is the Disconnect button gone to? I used that to disconnect from DWC when connected from remote to save bandwidth but it seems to be gone now.