Possible FTP Upload Problem

fcwilt

@chrishamm said in Possible FTP Upload Problem:

@fcwilt What Duet board are you using?

I am using a variety: Duet 2 WiFi/Duex 5 combo, Duet 3 Mini 5+ and Duet 3 6HC/3HC combo.

The Duet 2s are running 3.4.0.

The Duet 3 Mini 5+ and the Duet 3 6HC/3HC are running 3.4.1

At the risk of repeating myself, the things I am seeing:

files of size 0
files of size 0 that could not be updated via FileZilla - they had to be deleted. FileZilla reported no errors.
files of truncated size

To date I have not found any pattern.

Frederick

Phaedrux

Uploading these seems to be a good way to provoke it.

https://forum.duet3d.com/topic/6181/tuning-macros-menus-accel-jerk-retraction-pressure-advance

Sometimes they look like they are full size files, but on refreshing the directory they are 0 byte.

fcwilt

@chrishamm

I contacted the developer of the editor I am using that has the FTP client built-in.

He said it always uses just a single connection and always transfer just one file at a time.

Frederick

wschadow

I use filezilla in many cases But together with teh Duet boards I found that WinSCP is a bit more reliable. I have not looked into details.

chrishamm

@fcwilt I could reproduce those problems on a Duet 3 Mini 5+ WiFi and on a MB6HC. For both board types I have firmware fixes ready but I still need to check if the Duet 2 Ethernet is affected, too.

fcwilt

@chrishamm said in Possible FTP Upload Problem:

@fcwilt I could reproduce those problems on a Duet 3 Mini 5+ WiFi and on a MB6HC. For both board types I have firmware fixes ready but I still need to check if the Duet 2 Ethernet is affected, too.

Would the Duet 2 WiFi also be fixed by the changes for a Duet 2 Ethernet?

Frederick

chrishamm

@fcwilt Yes.

paunboli2

@chrishamm I'm also getting problem with old file explorer

chrishamm

@fcwilt @Phaedrux @wschadow You can find my updated v3.4.1+1 firmware builds for standalone mode here: https://pkg.duet3d.com/RRF-3.4.1plus1.zip Please let me know if they fix the FTP transfer problems. The issue where uploading config.g resulted in an empty file may be fixed by these builds, too.

fcwilt

@chrishamm said in Possible FTP Upload Problem:

@fcwilt @Phaedrux @wschadow You can find my updated v3.4.1+1 firmware builds for standalone mode here: https://pkg.duet3d.com/RRF-3.4.1plus1.zip Please let me know if they fix the FTP transfer problems. The issue where uploading config.g resulted in an empty file may be fixed by these builds, too.

I'm out of town for a few days.

I will test this new firmware as soon as I return home.

Thanks much.

Frederick

OwenD

@chrishamm
I just tried the following using FileZilla set to single connection and transfer limited to 500kb/s
On past usage all of these tests gave multiple zero kb files both directions

Bulk upload of all my filaments (25 directories each with 3 files) - OK
Bulk download of same - OK
Bulk download of complete system (700 files in 25 directories) - Only one failed transfer.
File was 0/www/css/OnScreenKeyboar
It was not 0kb, it failed to transfer. Re-queuing worked.
FileZilla didn't give a clear reason why the transfer of that file failed, but as it was reported I would call the test successful.

droftarts

@owend Was that with @chrishamm's updated firmware?

Ian

OwenD

@droftarts said in Possible FTP Upload Problem:

@owend Was that with @chrishamm's updated firmware?

Yes, it was.

fcwilt

@chrishamm

I finally returned home and tested the new FTP code.

On all of my printers (two Duet 2 WiFi, one 6HC and one Mini 5):

I was able to download all of the files from the SYS folder via my FTP client
I was able to upload all of the files to the SYS folder via my FTP client

No sign of file loss or truncation.

I will now continue with my normal activities using FTP and see if I encounter any problems.

Frederick

fcwilt

@chrishamm

I have returned to using my favorite editor in, for lack of a official term, FTP mode, where files are automatically download/uploaded as they are opened for editing and then saved when editing is done.

So far it seems to be working fine - though I have been keeping my fingers crossed.

JOOC what was it that you found and seem to have fixed?

Frederick

chrishamm

@fcwilt Thanks for confirming. All the network responders in RRF could ignore incoming data when a transfer had finished before incoming data was actually processed. So sometimes files could be truncated or when transfers timed out, the opened file would remain empty. It may also fix the issue some users had where config.g could be empty after uploading.

fcwilt

@chrishamm said in Possible FTP Upload Problem:

@fcwilt Thanks for confirming. All the network responders in RRF could ignore incoming data when a transfer had finished before incoming data was actually processed. So sometimes files could be truncated or when transfers timed out, the opened file would remain empty. It may also fix the issue some users had where config.g could be empty after uploading.

Thanks for the feedback.

I will alert you if I have any problems.

Frederick

fcwilt

@chrishamm

I just finished editing everyone of the 60 files on one of my printers (Duet 2 WiFi), using my editor in "FTP" mode.

FTP Mode Summary

when the editor opens the project the file names, in a specified folder, are downloaded from the printer and displayed as a list
when a filename in the list is clicked the editor downloads the file from the printer and opens it in the editing window
when the edited file is saved the editor uploads the file back to the printer

I made non-trivial changes to each of the 60 files over three days.

So far no sign of corruption or truncation.

I will repeat the test on another printer which is using a Duet 3 Mini.

Frederick

fcwilt

@chrishamm

I just finished the same set of non-trivial changes to all of the 60 some files on a printer using a Duet 5 Mini.

All seems fine.

Frederick

Phaedrux

Thanks for verifying. Good to know this bug is finally squashed.