Error in the implementation of M591?

[wschadow]

The documentation of M591 says that an event is created and that filament-error.g will be executed if present. Only if not present the default action is taken (Pause print using pause.g and inform user via message box). I noticed that the message box always opens when an "error" occurs.

My expectation would be that when you "catch" the error in filament-error.g the window should not pop-up.

More general it must not be an "error", it could be just an "event". When you invert the sensor P1 <-> P2 is can can in autoload or run-out mode. As a work around I use the sensor as a trigger when in autoload mode, and a sfilament sensor when in run-out mode. This is working nicely but when trying to evaluate the status of the sensor and no filament is loaded the info window pos-up.

[Phaedrux]

So you'd like an option to suppress the error message pop up?

What firmware version are you running?

[wschadow]

@phaedrux Yes, such an option would be great. The user sees these "errors". They are not alwyas erros in a strict sense but are events that can be handled intentionally and properly.

It's a bit annoying when a window pops-up on the PanelDue and the user gets an information he does'nt need.

I think an error should only be thrown in this case when it's not handled properly.

That was tested on 3.4.1

[dc42]

@wschadow are you sure that your filament-error.g file was catching the error?

[wschadow]

@dc42 Yes, I'm pretty sure that filament-error.g is executed. The sensor is configured as M591 D0 P1 C"e0stop" S1. In my case it will trigger when filament is inserted.

filament-error.g looks like this:

; =========================================================================================================
;
; called when a filament error occurs
;
; =========================================================================================================
;
M291 P"welcome to filament error"
echo "welcome to filament error"

; turn sensor off
M591 D0 P1 C"e0stop" S0
; =========================================================================================================
;

This is what happens, when filament is inserted. First on the Panel first the error message pops-up:

Then a split secend later the message from filament-error.g pops-up

The console looks like this:

Here the message from filament-error.g is displayed first.

According to the documentation the filament-erro message should not be displayed. In my opinion this is the preferrable way of implementation.