InputShaping-Plugin-0.1.0-rc6 released

SIam

@heartleander81 ~~have you installed DuetWebControl-SD.zip from the Release 3.4.0 beta 2 ?~~

jay_s_uk

@siam don't install that. it'll break DWC on an SBC build

mfs12

@caijonas you get the error message "session does not match record's numer of samples" when you try to load different "records" with different numbers of samples.

Ususally you try to compare graphs from different recordings sessions where you were using different paramters. They are not comparable. At least so far.

jay_s_uk

@mfs12 i get that message when loading different graphs recorded using the same parameters

mfs12

@jay_s_uk did one graph have overflows?

jay_s_uk

@mfs12 how do I verify that?

jay_s_uk

@mfs12 just looked at the files and all 3 have no overflows
input-shaping-0-Z-none.csv
input-shaping-0-Y-none.csv
input-shaping-0-X-none.csv

mfs12

@jay_s_uk if there were overflows you usually get asked. At least if it's the first record to load.

Or download the files and count the lines on Linux/MacOS you can use "wc -l" for that.

$ cat RECORDED_FILE.csv | wc -l

Here's the check that is failing...

https://github.com/mfs12/DuetWebControl/blob/ef667f55bcc6043a48eb72e2769726a9a9d5a8d4/src/plugins/InputShaping/InputShapingSession.js#L185

mfs12

just checked. the line counts are ok.

mfs12

@jay_s_uk but they are not exactly the same. you should get an sample rate error and not a sample number error.

The files use different sample rates.

==> 1629703252758-input-shaping-0-z-none.csv <==
Rate 1286, overflows 0

==> 1629703255890-input-shaping-0-y-none.csv <==
Rate 1284, overflows 0

==> 1629703258730-input-shaping-0-x-none.csv <==
Rate 1284, overflows 0

jay_s_uk

@mfs12 so how so I adjust that? they were all recorded using the input shaper plugin

mfs12

@jay_s_uk the easiest way would be to re-record them without tweaking any recording parameters.

jay_s_uk

@mfs12 ok, i've re-recorded and that error has gone. don;t know why it was there in the first place as I hadn't changed any of the parameters

dc42

@jay_s_uk @mfs12 the recorded rate may vary depending on temperature etc. RRF asks the sensor to report at one of its supported nominal rates, then measures the rate at which the sensor actually collects the data. Assuming that the sensor was a LIS3DH then the nominal rate would have been 1344. In this case the change in data rate was less than 0.2% so it could safely be ignored.

CadetC

@mfs12
Look like we need rc7
After installing 3.4b3 rc6 no longer works.

Nuramori

I get the following error:

Prerequisites
Duet Web Control
Version 3.4.0-b3

But I have that installed.

jay_s_uk

@nuramori it needs to be rebuilt for beta 3. It only works on beta 2

mfs12

Thanks for the feedback.

I plan to do another release towards the end of the week.

Fred-Y

@mfs12 That's a detail: when configuring the Input Shaping to none, there is a validation on the frequency - it's not really an issue but Algorithm = none and Frequency = 0 are the defaulted values.

Also, in the filename, would it be possible to include the parameters (frequency and damping) used?
It would be useful when comparing the different graphs.

GeneRisi

This post is deleted!