3.5.0.beta.3 plugin install leaves old files in /opt/dsf/dwc/css

stuartofmt

During plugin development, I have noticed that many old plugin files .gz .css are left in the /opt/dsf/dwc/css folder. It appears that new files are added at each install but old files are not being cleaned up (removed).

I'm reporting it here per the instructions in github. Not sure whether to describe this as a bug or an enhancement request.

dc42

@stuartofmt I'm tagging @chrishamm to look at this.

chrishamm

@stuartofmt Are you sure those files don't originate from a custom DWC build that you uploaded before? When you upgrade a plugin, DSF uninstall the old plugin first (excluding potential config files) and it removes DSF/DWC/SD files that should be provided by the following installation.

stuartofmt

@chrishamm said in 3.5.0.beta.3 plugin install leaves old files in /opt/dsf/dwc/css:

@stuartofmt Are you sure those files don't originate from a custom DWC build that you uploaded before? When you upgrade a plugin, DSF uninstall the old plugin first (excluding potential config files) and it removes DSF/DWC/SD files that should be provided by the following installation.

They are definitely from a custom DWC build. I have been making minor changes and testing them. All have installed without error. Yesterday, I cleaned out about 20 or so "duplicate" pairs.

Today there were 2 pairs. It appears (see below) that the build process creates the .css and .gz files with a hash (based on the file contents). These files are being added but never deleted.

pi@srsender:/opt/dsf/dwc/css $ ls | grep -i duetlapse3
DuetLapse3.dc82e4e2.css
DuetLapse3.dc82e4e2.css.gz
DuetLapse3.f45a1614.css
DuetLapse3.f45a1614.css.gz

Using DWC:

I uninstall / reinstall (from the same zip file) . Nothing changes.
I rebuildt the plugin with minor change (i.e. a comment added) and install from the new zip file - a new pair of files appears.

pi@srsender:/opt/dsf/dwc/css $ ls | grep -i duetlapse3
DuetLapse3.bd1eb9ed.css
DuetLapse3.bd1eb9ed.css.gz
DuetLapse3.dc82e4e2.css
DuetLapse3.dc82e4e2.css.gz
DuetLapse3.f45a1614.css
DuetLapse3.f45a1614.css.gz

I uninstalled from step 2 and reinstall using the zip file from step 1 - nothing changed (still 3 pairs of files)
I rebuilt the plugin from step 2 with zero changes. Uninstalled, installed from the new zip file. No new files were added.

chrishamm

@stuartofmt I will investigate.

chrishamm

@stuartofmt Thanks, you're right - I could reproduce this. I will fix it in 3.4.6 and 3.5-b4.