RRFLibraries commit "Added StringBuffer class..." broke builds

gtj0

@dc42 With this commit, building RRF v3-dev is seriously broken.

9:52:38 Build Failed. 370 errors, 0 warnings. (took 3s.566ms)
All String related.

Did you forget to 'git add' the new file?

commit bd39f4ca6f47f444251eef9a4cf9027a5c72b7f1
Author: David Crocker <dcrocker@eschertech.com>
Date:   Wed Jan 8 12:37:21 2020 +0000

    Added StringBuffer class and moved String class to a separate file

dc42

Development of RRF currently takes place on the v3.01-dev branch. To compile the v3.0-dev branch with the new RRFlibraries project, you would need to replace General/StringRef.h in several #include directives by General/String.h.

gtj0

v3.01-dev doesn't build either...

./src/Heating/Heat.cpp:74:172: error: 'class ReadLockedPointer<TemperatureSensor>' has no member named 'Ptr'; did you mean 'ptr'?

dc42

I'm sorry about that, I forgot to push RRFLibraries. Should be OK now.

I think v3.0 should build if you use the master branch of RRFLibraries instead of dev, because I updated master from dev before I made incompatible changes to it.

btw I recall that you were asking about retrieving heater data a few months ago. That may now be possible using the current 3.1 build.

gtj0

@dc42 Cool! I'll take a look at the heater stuff tomorrow.

dc42

@gtj0 said in RRFLibraries commit "Added StringBuffer class..." broke builds:

@dc42 Cool! I'll take a look at the heater stuff tomorrow.

To see all the values you can currently retrieve from the object model, send M408 P1 with no F parameter. There are many more values to be added. Let me know if the properties you need are not included; the framework is mostly complete, so it is relatively easy for me to add additional properties.

You can use the F parameter of the M408 P1 command to retrieve specific values. In due course we will provide a rr_ HTML request to provide the same functionality as M408 P1.

Notes:

The names of the object model variables are provisional and liable to change before I release RRF 3.1.
Conditional GCode in RRF 3.1beta currently works on Duet 2 and on Duet 3 in standalone mode, but not on Duet 3 with attached SBC.

gtj0

Only my bed heater shows now. No extruder... Not being passed to DSF either.

From the Duet3 USB Serial port...

M308 S1
Sensor 1 (HotEnd) type Thermistor using pin temp1, reading 224.3, last error: success, T:100000.0 B:4725.0 C:7.06e-8 R:2200.0 L:0 H:0

M308 S0
Sensor 0 (Bed) type Thermistor using pin temp0, reading 30.8, last error: success, T:100000.0 B:4138.0 C:0.00e+0 R:2200.0 L:0 H:0

M408 P1
<snip>
   "Heat" : {
      "ColdExtrudeTemperatu re" : 160,
      "ColdRetractTemperature" : 90,
      "Heaters" : [
         {
            "Current" : 31.5,
            "Sensor" : 0,
            "State" : "Off"
         }
      ],
      "Sensors" : [
         {
            "LastReading" : 31.5,
            "Name" : "Bed",
            "Type" : "Thermistor"
         },
         {
            "LastReading" : 23.3,
            "Name" : "HotEnd",
            "Type" : "Thermistor"
         },
         {
            "LastReading" : 31.1,
            "Name" : "Bed Check",
            "Type" : "T hermistor"
         },
         {
            "LastReading" : 22.4,
            "Name" : "Ambient",
            "Type" : "Thermistor"
         }
      ]
   },
<snip>

dc42

DSF currently keeps only a few object model parameters up to date. The hot end heater should show up in M408 P1 if you have configured it successfully. But this is very new code, so it may well contain bugs.

gtj0

@dc42 said in RRFLibraries commit "Added StringBuffer class..." broke builds:

DSF currently keeps only a few object model parameters up to date. The hot end heater should show up in M408 P1 if you have configured it successfully. But this is very new code, so it may well contain bugs.

Yeah it's definitely configured and I can control it. No worries though.

BTW, did you see my response about Cancel in https://github.com/chrishamm/DuetSoftwareFramework/issues/94

gtjoseph created this issue in chrishamm/DuetSoftwareFramework

closed Still having issues with Cancel in DSF 1.2.2.0 #94

dc42

@gtj0 said in RRFLibraries commit "Added StringBuffer class..." broke builds:

Only my bed heater shows now. No extruder... Not being passed to DSF either.

Should be fixed in latest 3.1 commit.

gtj0

@dc42 said in RRFLibraries commit "Added StringBuffer class..." broke builds:

@gtj0 said in RRFLibraries commit "Added StringBuffer class..." broke builds:

Only my bed heater shows now. No extruder... Not being passed to DSF either.

Should be fixed in latest 3.1 commit.

Thanks!