3.5: Linux build of CrcAppender isn't marked executable

gtj0

...so the final build step fails. Github issue and PR forthcoming.

droftarts

@gtj0 So set it as an executable? It says to do that in the MacOS instructions, step 3 https://github.com/Duet3D/RepRapFirmware/wiki/Building-RepRapFirmware#instructions-for-building-under-macos

Ian

gtj0

@droftarts said in 3.5: Linux build of CrcAppender isn't marked executable:

@gtj0 So set it as an executable? It says to do that in the MacOS instructions, step 3 https://github.com/Duet3D/RepRapFirmware/wiki/Building-RepRapFirmware#instructions-for-building-under-macos

Ian

Well, it was executable in 3.4 and setting it to executable makes a change in the git index so the tree is marked dirty.

gtj0

Actually, while we're talking about it, how about also changing CrcAppender in the post-build step that appends the crc to...

`"${workspace_loc:/${ProjName}/Tools/CrcAppender/${OsType}-x86_64/CrcAppender}"

On Linux, ${OsType} resolves to linux.
On Windows, it resolves to win32 (even on 64 bit).
Not sure about macos but it wold be easy enough to find out. Probably macos or osx.

It would require renaming the directories under Tools/CrcAppender but it would remove the need for users to copy the appropriate binary to a directory outside the project that's already in their PATH.

droftarts

@gtj0 That would be good. @dc42 ?

Ian

dc42

@gtj0 good idea! What does OsType resolve to on a Mac?

gtj0

@dc42 said in 3.5: Linux build of CrcAppender isn't marked executable:

@gtj0 good idea! What does OsType resolve to on a Mac?

According to org.eclipse.core.runtime.Platform, OsType is one of...

public static final String OS_WIN32 = "win32";
public static final String OS_LINUX = "linux";
public static final String OS_MACOSX = "macosx";

There are others for aix, solaris, hpux, etc but I don't think we care about them

gtj0

@dc42 Are you going to do this or should I submit a pull request for it?