Help for translation needed
-
Hey @Fred-Y, yes, translations where added. Although there was only one suggested change in french. Or did i miss something. I found just one comment.
And this entry got meanwhile obsolete for all languages.
-
On the one hand 5.0i and 7.0i are separated, is there a reason? what do they change?
No, just the new build process. I thought it's nice to have explicit builds for every device. But it looks like there are going to be merged again into one image.
-
@mfs12 I'm not familiar with GitHub, I added many corrections, I'm not quite sure why you didn't see them - they are all "Pending".
I have surely missed somethingLet me know how to fix this and I will do it asap.
-
@Fred-Y this is weird. never saw this "pending" status before.
Did you use this link?
https://github.com/mfs12/PanelDueFirmware/pull/2/files
can you share the link from where you took the screenshot?
-
@mfs12 It's coming from the same link you posted above
-
@mfs12 I think I figured out!
I had this button to submit my review
Can you see my comments now?
-
@Fred-Y yes, now everything appeared.
It will get in with the next release.
-
@mfs12 Perfect!
I will try to install it as soon as it is released and switch to French to make sure it looks good. -
@Fred-Y i commented some stuff.
Status values must not be longer then 15 characters otherwise they are cut off.
Please check
And here are the actual changes i did so far.
-
Translate.txt
Translation into Russian. -
Hey @romanvin, it would be helpful to comment on the changes at github. Otherwise managing all the changes will be pretty hard.
Please check
https://github.com/mfs12/PanelDueFirmware/pull/2#issuecomment-909913840
-
@mfs12 I adjusted the status, they should all be 15 chr or less.
Let me know if I missed something -
@RomanVin thanks for your help!
I created a pull request with most of you changes. I two changes i didn't take because they were too long.
If you want to have a last look on the changes feel free to comment in the pull request.
-
@mfs12, do you use an online service to manage the collaborative translation? They can be very handy. E.g https://crowdin.com/page/open-source-project-setup-request
-
Hey @zapta, no, i didn't think of that when i started the task. But realized things like this exist. So far we are using github pull request to check translations. In the end i am updating the sources manually. Not ideal but so far only small portions need to be replaced.
Recently i also stumbled over weblate which sounds also interesting.
-
Hi. I can also help with translation into Russian.
-
@vladimir_u said in Help for translation needed:
Hi. I can also help with translation into Russian.
Thank you, but Russian is already done. But testing the next release would be helpful as well.
-
@mfs12 I just installed the 3.4.0-pre3 to check the French translation, how/where do you want the adjustment to be submitted?
I've seen a few details I would like to correct if possible.
-
@Fred-Y, i updated the review PR. So leave your comments there. Thanks.
-
@mfs12 I finished my review.
9 Adjustments / responses to your comments.